Skip to content

Remove excess cast to C-string and add const references for read-only objects #784

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Remove excess cast to C-string and add const references for read-only objects #784

wants to merge 1 commit into from

Conversation

GermanAizek
Copy link
Contributor

@GermanAizek GermanAizek commented Dec 18, 2024 •
edited
Loading

@JablonskiMateusz
Copy link
Contributor

@GermanAizek please short commit msg title, not to exceed 80 characters

@GermanAizek
Copy link
Contributor Author

@GermanAizek please short commit msg title, not to exceed 80 characters

fix it 81f48bb

@JablonskiMateusz
Copy link
Contributor

Now, since we have 2025 please update year in copyright header in modified files

@GermanAizek
Copy link
Contributor Author

Now, since we have 2025 please update year in copyright header in modified files

Fixed it in this 90005f5

@JablonskiMateusz
Copy link
Contributor

Commit author does not match author in Signed-off-by, please correct that:

Author: Herman Semenov [email protected]

Signed-off-by: Semenov Herman (Семенов Герман) [email protected]

@GermanAizek
refactor: remove excess cast to C-string and add const reference
6ff79a0 
Signed-off-by: Semenov Herman (Семенов Герман) <[email protected]>
@GermanAizek
Copy link
Contributor Author

Commit author does not match author in Signed-off-by

fixed it in 6ff79a0 ?

@JablonskiMateusz
Copy link
Contributor

@GermanAizek it was then reverted in 242a31a due to some function issues

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@GermanAizek @JablonskiMateusz